From 2a9fa81e560afc2b144e153f10b9857a44313928 Mon Sep 17 00:00:00 2001
From: yukaidi <yukaidi@duck.com>
Date: Fri, 29 May 2026 07:02:23 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20CacheManager=20registerPeriodicCleanup?=
 =?UTF-8?q?=20=E6=B7=BB=E5=8A=A0=E9=98=B2=E9=87=8D=E5=85=A5=E5=92=8C=20Ver?=
 =?UTF-8?q?tx=20=E5=B0=B1=E7=BB=AA=E6=A3=80=E6=9F=A5?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

审查发现 static 块中注册定时任务存在时序风险：如果 CacheServiceImpl 在 Vertx
初始化前被加载，定时任务将注册失败且无法恢复。添加 cleanupRegistered 标志防止
重复注册，Vertx 未就绪时跳过并等待下次调用。
---
 .../main/java/cn/qaiu/lz/common/cache/CacheManager.java   | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/web-service/src/main/java/cn/qaiu/lz/common/cache/CacheManager.java b/web-service/src/main/java/cn/qaiu/lz/common/cache/CacheManager.java
index 3980721..947670d 100644
--- a/web-service/src/main/java/cn/qaiu/lz/common/cache/CacheManager.java
+++ b/web-service/src/main/java/cn/qaiu/lz/common/cache/CacheManager.java
@@ -232,9 +232,17 @@ public class CacheManager {
      * 注册定时清理过期缓存任务（每小时执行一次）
      * 应在应用启动后调用
      */
+    private static volatile boolean cleanupRegistered = false;
+
     public static void registerPeriodicCleanup() {
+        if (cleanupRegistered) return;
         try {
             io.vertx.core.Vertx vertx = cn.qaiu.vx.core.util.VertxHolder.getVertxInstance();
+            if (vertx == null) {
+                LOGGER.warn("Vertx 未就绪，缓存定时清理任务延迟注册");
+                return;
+            }
+            cleanupRegistered = true;
             vertx.setPeriodic(3600_000, 3600_000, id -> {
                 try {
                     new CacheManager().cleanupExpiredCache();